Apply Rector: CountArrayToEmptyArrayComparisonRector - #3839
Merged
samsonasik merged 1 commit intoOct 30, 2020
Conversation
Change count array comparison to empty array comparison to improve performance
Member
Author
|
All green 🎉 |
paulbalandan
left a comment
paulbalandan
left a comment
Member
There was a problem hiding this comment.
I've seen this trend in some repo. Is this check also more performant than truthy checks? I mean if if ($array !== [] is faster than if ($array)?
Member
Author
|
Checked benchmark with 1000000 at https://phpsandbox.io/n/cool-limit-q2mg seems sometime faster, sometime slower, or same. Tested locally, compare with |
samsonasik
deleted the
apply-rector-count-array-to-empty-array-comparison
branch
October 30, 2020 19:29
Member
Author
|
@paulbalandan thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change count array comparison to empty array comparison to improve performance
Checklist: